Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to backup overview settings #23368

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 20, 2024

Proposed change

Add links to backup overview settings. I'm not very happy about the implementation but it works

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:


private async _scrollToSection() {
const hash = window.location.hash.substring(1);
if (hash === "locations" && isComponentLoaded(this.hass, "hassio")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we only do this if addons is set to custom?

@piitaya piitaya force-pushed the backup-overview-settings-links branch from 2796ed8 to 8b92713 Compare December 20, 2024 19:54
@bramkragten bramkragten merged commit 379bc3a into dev Dec 20, 2024
15 checks passed
@bramkragten bramkragten deleted the backup-overview-settings-links branch December 20, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants